-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make learn more links clickable for automation v2 [WPB-5888] #3044
Conversation
Test Results928 tests 928 ✅ 13m 0s ⏱️ Results for commit 0cf11dc. ♻️ This comment has been updated with latest results. |
Quality Gate passedIssues Measures |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 5042 succeeded. The build produced the following APK's: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please make this change in develop only
Closing as it's not meant to be merged into 4.7, PR for 4.8 is here: #3064 |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
This is a next approach to fix this issue: https://wearezeta.atlassian.net/browse/WPB-5888
Issues
Previous fix, although looking fine on devices and layout inspector, was not working for automation, because it can't use
testTags
and it can't find inline content text composable.Solutions
In this PR, link text composable is extracted out of the inline content of the main text - inline content only contains a placeholder box to position the link correctly inside the text and to get valid size and position of that link to create the proper link text composable. Inline content is still used to make it work for all locales, no matter if the link is inside the text or at the end or if it's LTR or RTL.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.