Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make learn more links clickable for automation v2 [WPB-5888] #3044

Closed

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented May 28, 2024

TaskWPB-5888 [Android] Separate links from dialogs - enabling automated testing


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

This is a next approach to fix this issue: https://wearezeta.atlassian.net/browse/WPB-5888

Issues

Previous fix, although looking fine on devices and layout inspector, was not working for automation, because it can't use testTags and it can't find inline content text composable.

Solutions

In this PR, link text composable is extracted out of the inline content of the main text - inline content only contains a placeholder box to position the link correctly inside the text and to get valid size and position of that link to create the proper link text composable. Inline content is still used to make it work for all locales, no matter if the link is inside the text or at the end or if it's LTR or RTL.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented May 28, 2024

Test Results

928 tests   928 ✅  13m 0s ⏱️
123 suites    0 💤
123 files      0 ❌

Results for commit 0cf11dc.

♻️ This comment has been updated with latest results.

Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@saleniuk saleniuk requested review from a team, typfel, alexandreferris, borichellow, mchenani and ohassine and removed request for a team May 28, 2024 10:48
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 5042 succeeded.

The build produced the following APK's:

Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please make this change in develop only

@saleniuk
Copy link
Contributor Author

saleniuk commented Jun 3, 2024

Closing as it's not meant to be merged into 4.7, PR for 4.8 is here: #3064

@saleniuk saleniuk closed this Jun 3, 2024
@saleniuk saleniuk deleted the fix/links-clickable-for-automation-v2 branch June 19, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants